From 756e16b533edf4edbedbe9d55dc11d54ae4724f7 Mon Sep 17 00:00:00 2001 From: Daniel Winzen Date: Thu, 6 Dec 2018 16:54:35 +0100 Subject: [PATCH] Fixed potential race condition pointed out in issue #31 --- var/www/cron.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/var/www/cron.php b/var/www/cron.php index 8d161b3..4e4f055 100644 --- a/var/www/cron.php +++ b/var/www/cron.php @@ -117,10 +117,9 @@ foreach($onions as $onion){ if($onion[2]==2){ //php openssl implementation has some issues, re-export using native openssl $pkey=openssl_pkey_get_private($onion[1]); - openssl_pkey_export_to_file($pkey, 'key.tmp'); + openssl_pkey_export($pkey, $exported); openssl_pkey_free($pkey); - $priv_key=shell_exec('openssl rsa < key.tmp'); - unlink('key.tmp'); + $priv_key=shell_exec('echo ' . escapeshellarg($exported) . ' | openssl rsa'); //save hidden service mkdir("/var/lib/tor-instances/$firstchar/hidden_service_$onion[0].onion", 0700); file_put_contents("/var/lib/tor-instances/$firstchar/hidden_service_$onion[0].onion/private_key", $priv_key);