diff --git a/CHANGELOG b/CHANGELOG
index 81cf44b..4c400da 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,3 +1,5 @@
+Properly escape some parameters
+
Version 1.16.3 - Apr. 14, 2016
Fix warning on redirection of links without a scheme
diff --git a/chat.php b/chat.php
index dd79df0..bdd1785 100644
--- a/chat.php
+++ b/chat.php
@@ -219,8 +219,15 @@ if(!isSet($_REQUEST['action'])){
foreach($C['number_settings'] as $setting){
settype($_REQUEST[$setting], 'int');
}
+ settype($_REQUEST['guestaccess'], 'int');
+ settype($_REQUEST['englobalpass'], 'int');
+ settype($_REQUEST['captcha'], 'int');
+ settype($_REQUEST['dismemcaptcha'], 'int');
+ settype($_REQUEST['guestreg'], 'int');
$_REQUEST['rulestxt']=preg_replace("/(\r?\n|\r\n?)/", '
', $_REQUEST['rulestxt']);
$_REQUEST['chatname']=htmlspecialchars($_REQUEST['chatname']);
+ $_REQUEST['redirect']=htmlspecialchars($_REQUEST['redirect']);
+ $_REQUEST['css']=htmlspecialchars($_REQUEST['css']);
if(!preg_match('/^[a-f0-9]{6}$/i', $_REQUEST['colbg'])){
unset($_REQUEST['colbg']);
}
@@ -252,7 +259,9 @@ if(!isSet($_REQUEST['action'])){
$_REQUEST['numnotes']=1;
}
foreach($C['settings'] as $setting){
- if(isSet($_REQUEST[$setting])) update_setting($setting, $_REQUEST[$setting]);
+ if(isSet($_REQUEST[$setting])){
+ update_setting($setting, $_REQUEST[$setting]);
+ }
}
}elseif($_REQUEST['do']==='backup' && $U['status']==8){
send_backup();
@@ -806,7 +815,7 @@ function send_init(){
echo '
$I[changelang]"; foreach($L as $lang=>$name){ - echo " $name"; + echo " $name"; } echo "
$H[credit]"; print_end(); @@ -829,7 +838,7 @@ function send_alogin(){ echo '$I[changelang]"; foreach($L as $lang=>$name){ - echo " $name"; + echo " $name"; } echo "
$H[credit]"; print_end(); @@ -1668,7 +1677,7 @@ function send_profile($arg=''){ echo ""; thr(); if(!isSet($_COOKIE[COOKIENAME])){ - $param="&session=$U[session]&lang=$language"; + $param="&session=$U[session]&lang=$language"; }else{ $param=''; } @@ -1757,7 +1766,7 @@ function send_profile($arg=''){ echo '$I[changelang]"; foreach($L as $lang=>$name){ - echo " $name"; + echo " $name"; } echo '
'; echo "