From cac94d3151b9af488d3d4ea9f12171ea6d01198d Mon Sep 17 00:00:00 2001 From: Wolf Date: Mon, 31 Jan 2022 11:36:51 +0100 Subject: [PATCH 1/4] you do not need "text/css"-type for style-tags --- chat.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/chat.php b/chat.php index 719dbdc..49eeb65 100644 --- a/chat.php +++ b/chat.php @@ -305,12 +305,12 @@ function prepare_stylesheets(bool $init = false){ function print_stylesheet(bool $init = false){ global $styles; //default css - echo ""; + echo ""; if($init){ return; } //overwrite with custom css - echo ""; + echo ""; } function print_end(){ @@ -2243,7 +2243,7 @@ function send_fatal_error(string $err){ send_headers(); echo ''.meta_html(); echo "$I[fatalerror]"; - echo ""; + echo ""; echo ''; echo "

$I[fatalerror]: $err

"; print_end(); From bb2cc200a682328fde4fc88a9cce55922630e0f8 Mon Sep 17 00:00:00 2001 From: Wolf Date: Mon, 31 Jan 2022 11:37:36 +0100 Subject: [PATCH 2/4] fixed some translation (de) --- lang_de.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lang_de.php b/lang_de.php index afb5b4b..c6a4202 100644 --- a/lang_de.php +++ b/lang_de.php @@ -178,7 +178,7 @@ $T=[ 'colourtable' => 'Farbtabelle', 'backtoprofile' => 'Zurück zu Ihrem Profil', 'copy' => 'Kopiere:', - 'choosecol' => 'Gast, suchen dir eine Farbe aus:', + 'choosecol' => 'Textfarbe auswählen:', 'randomcol' => 'Zufällige Farbe', 'enter' => 'Chat beitreten', 'error' => 'Fehler', @@ -326,7 +326,7 @@ $T=[ 'mailsender' => 'E-Mail mit dieser Adresse versenden', 'mailreceiver' => 'E-Mail and diese Adresse senden', 'modfallback' => 'Auf Warteraum rückgreifen, falls kein Moderator anwesend ist, um Gäste hereinzulassen', - 'regpass' => 'Zum registrieren
Passwort wiederholen', + 'regpass' => 'Passwortwiederholung
(zur Neuregistrierung)', 'guestreg' => 'Gäste sich selbst registrieren lassen', 'asmember' => 'Als Mitglied', 'assuguest' => 'Als Anwerber', @@ -342,7 +342,7 @@ $T=[ 'tz' => 'Zeitzone', 'optional' => '(optional)', 'userloggedin' => 'Ein Nutzer mit diesem Nicknamen ist bereits angemeldet.', - 'regednick' => 'Dieser Nickname ist ein registeriertes Mitglied.', + 'regednick' => 'Dieser Nickname ist bereits ein registriertes Mitglied.', 'failednotice' => 'Fehlgeschlagener Anmeldeversuch(n)', 'dismiss' => 'entlassen', 'eninbox' => 'Offline Posteingang aktivieren', From bf6036770416b51a6342b26f490abcc3be687f8d Mon Sep 17 00:00:00 2001 From: Wolf Date: Mon, 31 Jan 2022 11:38:10 +0100 Subject: [PATCH 3/4] you do not need to escape " in ' --- chat.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/chat.php b/chat.php index 49eeb65..ddb5007 100644 --- a/chat.php +++ b/chat.php @@ -2311,11 +2311,11 @@ function print_chatters(){ echo "
$I[staff]: ".implode('   ', $S).''; } if($U['status']>=3){ // can chat in member channel - echo '' . $channellink . 's ?" target="post">
' . $I['members'] . ': '.implode('   ', $M).''; + echo '' . $channellink . 's ?" target="post">
' . $I['members'] . ': '.implode('   ', $M).''; } else { echo "
$I[members]: ".implode('   ', $M).''; } - echo '' . $channellink . 's *" target="post">
' . $I['guests'] . ': '.implode('   ', $G).''; + echo '' . $channellink . 's *" target="post">
' . $I['guests'] . ': '.implode('   ', $G).''; echo ''; } } From 062fac127828b664baa60daff7453fdc0b82e8ef Mon Sep 17 00:00:00 2001 From: Wolf Date: Mon, 31 Jan 2022 11:38:54 +0100 Subject: [PATCH 4/4] use urlencode in urls (was htmlspecialchars) --- chat.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chat.php b/chat.php index ddb5007..d673d5a 100644 --- a/chat.php +++ b/chat.php @@ -2289,7 +2289,7 @@ function print_chatters(){ $channellink="fetch(PDO::FETCH_NUM)){ - $link=$nicklink.htmlspecialchars($user[0]).'" target="post">'.style_this(htmlspecialchars($user[0]), $user[1]).''; + $link=$nicklink.urlencode($user[0]).'" target="post">'.style_this(htmlspecialchars($user[0]), $user[1]).''; if($user[2]<3){ // guest or superguest $G[]=$link; } elseif($user[2]>=7){ // admin or superadmin